Jlo fixes/rltime relative time adjustments#21
Open
johannes-lode wants to merge 12 commits intopvbrowser:masterfrom
Open
Jlo fixes/rltime relative time adjustments#21johannes-lode wants to merge 12 commits intopvbrowser:masterfrom
johannes-lode wants to merge 12 commits intopvbrowser:masterfrom
Conversation
added 3 commits
January 21, 2019 16:11
To avoid time calculation errors by mixing absolute time values with relative time value in the same class, the interface was changed for the application of relative amounts of time against absolute points in time. Added interface for simple formatting options of time differences.
Intermediate commit for transfer to another workstation.
Owner
|
Looks good. Please give me some time for testing. Also i have an idea howto make both (old/new) version of rlTime available in 1 library by using namespaces. |
Meanwhile added a proxy interface, so the traditional interface of operating with two operands of rlTimeEx is available. One small exception is there of returning double for the difference of two rlTimeEx object by default and returning rlTimeEx objects only on request by casting the second operand to RelativeTime(rltime_object).
Assertions and type conversion rules ensure to combine only valid types of time (only one absolute time in addition or subtraction, all others need to be relative time values)
jlo-fixes/rltime-relative-time-adjustments Conflicts: .gitignore - resolved by mix-in rllib/lib/lib.pro - resolved by mix-in rllib/lib/rltime_v2.cpp - resolved by using my version rllib/lib/rltime_v2.h - resolved by using my version
Author
|
Merged all the new structure from the master branch to make the pull/merge easier. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
To avoid time calculation errors by mixing absolute time values with
relative time value in the same class, the interface was changed for the
application of relative amounts of time against absolute points in time.
Added interface for simple formatting options of time differences.
Please, let's discuss pros and cons of this suggestion.
This patch includes also changes on other classes induced by the interface change of rlTime, to show how simple they are, in a lot of places, where rlTime objects are accessed, no changes are nessessary. Sometimes the use of rlTime objects became simpler.